Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sequential handling on Patch jobs and objects #714

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

ygalblum
Copy link
Contributor

@ygalblum ygalblum commented Oct 21, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Sequential execution runs all objects in a job iteration before reiterating
It allows delaying between objects and/or job iterations
Add PatchExecutionType for backward compatibility

Related Tickets & Documents

@rsevilla87 rsevilla87 self-requested a review October 22, 2024 13:41
@rsevilla87 rsevilla87 added the enhancement New feature or request label Oct 22, 2024
Sequential execution runs all objects in a job iteration before reiterating
It allows delaying between objects and/or job iterations
Add PatchExecutionType for backward compatibility

Signed-off-by: Ygal Blum <[email protected]>
@ygalblum
Copy link
Contributor Author

ygalblum commented Nov 4, 2024

@rsevilla87 I've made the change we discussed regarding running list on every run and added a test that verifies that it in fact works.
As for documentation, I already had a section on the different execution mode. I guess that because I wrote the code, I don't see what's missing. But, please LMK what information you think is missing

Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsevilla87 rsevilla87 merged commit 6c6d34e into kube-burner:main Nov 5, 2024
7 checks passed
@ygalblum ygalblum deleted the sequential-patch branch March 19, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Add support for sequential patch job processing
2 participants