This repository has been archived by the owner on Dec 31, 2020. It is now read-only.
Added typescript typings for moment-holiday #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempted to implement the typings and related tests in the same fashion that moment itself does. Typings cover: * extensions to moment objects such as `holiday`, `isHoliday`, and so on * the `holidays` and `modifyHolidays` objects in the moment namespace Also contains an npm script to ensure that the typings match expected usage. TODO: * Provide typings for the actual shape of holiday definitions
Update tests to cover that as well. TODO: still not sure what the shape of `specifics` should be.
rwdalpe
added a commit
to rwdalpe/DefinitelyTyped
that referenced
this pull request
Oct 28, 2017
PR upstream to add typings in the library has been open for a while <kodie/moment-holiday#14> without feedback. Adding the typings here until that PR changes state.
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted to implement the typings and related tests in the same fashion that moment itself does.
Typings cover:
holiday,isHoliday, and so onholidaysandmodifyHolidaysobjects in the moment namespaceAlso contains an npm script to ensure that the typings match expected usage.