Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
auto-bind
package depends on@types/react
. If a TypeScript project is using JSX without using react, the@types/react
package can cause problems, as it defines a globalJSX
namespace that may conflict with alternative JSX typings from non-react packages.Users of this package may or may not be using react, so it seems like this package shouldn't rely on something react-specific.
auto-bind
is only used for bindingthis.middleware
, so it's a fairly simple change to remove it.Let me know if this sounds reasonable or if you have any questions/concerns.