Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto-bind dependency. #48

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

karthikv
Copy link
Contributor

@karthikv karthikv commented Sep 9, 2019

The auto-bind package depends on @types/react. If a TypeScript project is using JSX without using react, the @types/react package can cause problems, as it defines a global JSX namespace that may conflict with alternative JSX typings from non-react packages.

Users of this package may or may not be using react, so it seems like this package shouldn't rely on something react-specific. auto-bind is only used for binding this.middleware, so it's a fairly simple change to remove it.

Let me know if this sounds reasonable or if you have any questions/concerns.

test/test.js Show resolved Hide resolved
@niftylettuce niftylettuce merged commit 7dc7b2d into koajs:master Sep 9, 2019
@niftylettuce
Copy link
Contributor

Released in v3.0.8 🎉

npm install koa-csrf@latest

Thanks @karthikv

niftylettuce added a commit that referenced this pull request Sep 9, 2019
@karthikv
Copy link
Contributor Author

karthikv commented Sep 9, 2019

Thank you @niftylettuce! Really appreciate the fast turnaround 👍

@karthikv karthikv deleted the remove-auto-bind branch September 9, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants