Fix missing synthesis options during LSP initialization throws a NullPointerException #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Language server no longer throws a NullPointerException if a client does not specify synthesis options during lsp initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the LSP initialization process a client is able to specify persisted synthesis options. If no synthesis options are provided, the server currently throws (and catches) a
NullPointerException"Could not load client-side synthesis options" and continues to generates a diagram with default synthesis options anyway.However, a client is not always able to provide synthesis options, which makes the exception slightly irritating in such situations. For example, a KEITH Theia ide that is used for the first time or has cleared
localStoragedoes not have persisted options.This PR prevents the
NullPointExceptionby using an emptysynthesisOptionsobject if necessary.