Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klighd.lsp: Option can also be a Double. #112

Merged
merged 3 commits into from
Apr 28, 2022

Conversation

soerendomroes
Copy link
Member

No description provided.

@soerendomroes soerendomroes added the LSP Affect the klighd language server. label Apr 28, 2022
@NiklasRentzCAU
Copy link
Member

This is a new case that only happens due to values being sent differently wen clearing the persisted data (and with that resetting the options) for the diagrams. Therefore the same issue also happens for integer range options, the same check needs to be applied there as well. A Double will be sent by the client, to be converted for example via Math.round(value as Double) in the case a few lines above.

Copy link
Member

@NiklasRentzCAU NiklasRentzCAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NiklasRentzCAU NiklasRentzCAU merged commit e831700 into master Apr 28, 2022
@soerendomroes soerendomroes deleted the sdo/fixResetSynthesisOptions branch May 2, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP Affect the klighd language server.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants