Skip to content

[PERF] OpenTelemetry is initialized even when disabled#34031

Merged
mabartos merged 1 commit intokeycloak:mainfrom
mabartos:KC-33948
Oct 17, 2024
Merged

[PERF] OpenTelemetry is initialized even when disabled#34031
mabartos merged 1 commit intokeycloak:mainfrom
mabartos:KC-33948

Conversation

@mabartos
Copy link
Contributor

@mabartos mabartos commented Oct 17, 2024 •
edited
Loading

Change host reference in logging guide

No executions in OpenTelemetryProcessor anymore.

@mabartos
[PERF] OpenTelemetry is initialized even when disabled
bfaf554 
Change host reference in logging guide

Fixes keycloak#33948

Signed-off-by: Martin Bartoš <[email protected]>
@mabartos mabartos requested review from a team as code owners October 17, 2024 09:32
@mabartos mabartos mentioned this pull request Oct 17, 2024
Merged
@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 17, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcSamlBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Base IT (2)

java.lang.AssertionError: Did not find the event of expected type USER_DISABLED_BY_TEMPORARY_LOCKOUT. Events present: [IDENTITY_PROVIDER_POST_LOGIN_ERROR, IDENTITY_PROVIDER_POST_LOGIN_ERROR, IDENTITY_PROVIDER_POST_LOGIN_ERROR, IDENTITY_PROVIDER_POST_LOGIN_ERROR]
	at org.junit.Assert.fail(Assert.java:89)
	at org.keycloak.testsuite.AssertEvents$ExpectedEvent.assertEvent(AssertEvents.java:410)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:586)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 17, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@mabartos mabartos requested review from shawkins and vmuzikar October 17, 2024 11:12
shawkins
shawkins approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mabartos

@mabartos mabartos merged commit 637ca2e into keycloak:main Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shawkins shawkins shawkins approved these changes

@vmuzikar vmuzikar Awaiting requested review from vmuzikar

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PERF] OpenTelemetry is initialized even when disabled

2 participants

@mabartos @shawkins