include LICENSE.txt in source distributions, specify minimum python #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for this tool!
I'm looking to build this for conda-forge, and as such it's usually nice to have the authoritative license file included in the distribution... even though it's not strictly required by the MIT license.
This PR adds a
MANIFEST.inincluding the license, and tweaks thesetup.pymetadata a hair to include it and make the python requirement more explicit. No worries if you don't wish to make these changes, feel free to close, as I can just pull the license from the repo... though it would also be helpful to have git tags that coincide with the actual release versions for this purpose (just in case you do decide to change it).Thanks again!