patches/kernelci-pipeline: add timeout to trigger section
#99
Conversation
The `timeout` option has been introduced to configure `checkout` node timeout in `trigger` service. Add a default value of the option to staging config as well. Signed-off-by: Jeny Sadadia <[email protected]>
There was a problem hiding this comment.
One issue is that this file isn't used on staging. There's another one which is not in Git and has some secret tokens. We should probably add it as an encrypted file and replace these patches.
@nuclearcat How does that sound from a sysadmin pov?
|
I am worried that file contains configuration values that might be changed often and secrets update process are more complicated. |
|
It shouldn't be changing often, maybe a bit more during intensive development phases but then things should get stable in this respect. |
Yes, I forgot that we are using a different file now. Update the secrets one. |
We can also encrypt specific fields rather than encrypting whole file. |
|
Should we add it then in kernelci-jenkins-data repo or create new one for API/Pipeline? |
|
As i see by this repo, initially we just create env file and provide for software (jenkins, but pipeline can do it too) secrets over environment variables. |
|
I think we can just add an encrypted file to this repo, the Jenkins setup is actually quite clunky. @JenySadadia With git-crypt you can only encrypt whole files, see how it's setup in |
|
Closing the PR as we are not using |
The
timeoutoption has been introduced to configurecheckoutnode timeout intriggerservice.Add a default value of the option to staging config as well.