Add lock/unlock for build git, build, and install #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is kinda scope creep, but I found it during tests to the current branch...
The `cd` mechanism is kinda messy, but I didn't want to touch it as a whole (call it scope creep)
This'd only be visible on failure, but still it's nice to have it work as expected!
... with our expectations
jadeallenx
reviewed
Oct 17, 2023
kerl
Outdated
|
|
||
| if [ "$1" = "close" ]; then | ||
| if [ -f "$3/$2.lock" ]; then | ||
| error "trying to $2 in $3, but lock file ($3/$2.lock) exists!" |
There was a problem hiding this comment.
i think if the lock file is "old" (like more than 14 days) we should remove it/ignore it
There was a problem hiding this comment.
Oh, yeah, I can implement that.
There was a problem hiding this comment.
kerl
Outdated
|
|
||
| lock_close_build() { | ||
| # $_KERL_BUILD_DIR is global | ||
| lock "close" "build" "$_KERL_BUILD_DIR" |
There was a problem hiding this comment.
i dont understand open and close - i would prefer "lock" "unlock" lock_build unlock_build etc
There was a problem hiding this comment.
No prob. I thought of lock as a noun, not a verb, but a verb works too 👍 (so, in my mind, unlock would be open lock 😄). I'll change it.
There was a problem hiding this comment.
I wanted to have lock/unlock in the same function, to "control" the filename better, but they don't seem to be so far apart that it'll make a difference
paulo-ferraz-oliveira
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #187.
I've also reviewed all the scattered
exitstatements to turn them intoreturn(and act on that) in the scope of the changes. A few non- top-levelexitstatements still remain, though.Leaving this as a draft, for the time being, since I wanna self-review it (further) still...The change
What I did, mostly, was:
returninstead ofexitto ease debugging code flow and maintenance