shellcheck and shfmt generated files #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-16
to
-18
| - name: Check push (shfmt) | ||
| run: | | ||
| git diff --exit-code |
There was a problem hiding this comment.
-d is semantically equivalent to what I wanted to do before.
paulo-ferraz-oliveira
changed the title
jadeallenx
approved these changes
Sep 26, 2023
|
Thanks, @jadeallenx. I have more stuff to push 😄 I'll merge this without waiting for ✅ on macos 13, since those tend to take a really long time. |
paulo-ferraz-oliveira
deleted the
feature/sh-stuff-on-generated-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is just making sure our generated files are
shellcheck'ed andshfmt'ed. If we see this is an impediment to future pull requests we can revert it.Closes #462.