shfmt and shellcheck kerl and bash completion scripts #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Best seen if ignoring whitespace changes...
|
@jadeallenx, I'm adding you as a reviewer with at least one CI ✅ for the builds... |
jadeallenx
approved these changes
Sep 26, 2023
| @@ -52,6 +52,8 @@ and is repeatable in any way, should be tested, to guarantee backwards compatibl | |||
| - try not to introduce lines longer than 100 characters | |||
| - write small functions whenever possible, and use descriptive names for functions and variables | |||
| - comment tricky or non-obvious decisions made to explain their rationale | |||
| - the tool is linted with `shellcheck` and formatted with `shfmt`: make sure you run these locally | |||
| to avoid CI issues (their options are listed in `lint.yml`) | |||
There was a problem hiding this comment.
Lemme check. I think it's just GitHub acting up 😄
There was a problem hiding this comment.
I see it like this, newline after the word locally
or did you mean something else?
There was a problem hiding this comment.
In any case, since I got your approval, I'll go ahead and squash-merge to push more goodies. Feel free to reply to this and I'll act on it if there's something to change 😄
Thanks.
There was a problem hiding this comment.
Nothing to change, just wanted to make sure you wanted the text that way
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We add
shfmtto CI, while formatting the bash completion, tool scripts and test files. We also runshellcheckon those and hopefully properly fix the issues. Many commits were issued to potentially ease review. The formatting ones and "just" the result ofshfmton the updated scripts, but will still be part of my self-review.Motivation
This is basically a quality-of-life improvement, to have consistent formatting and (further) linting.