Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement build-install (as per #79) #418

Merged
merged 6 commits into from
May 9, 2023
Merged

Implement build-install (as per #79) #418

merged 6 commits into from
May 9, 2023

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Sep 21, 2022 •
edited
Loading

I'm still missing the bash and zsh completions, for which I have limited experience, but hope to do them in the scope of this pull request, when time allows.

Closes #79.

TODO:

  • shell completion update for zsh
  • shell completion update for bash
  • tests for CircleCI GitHub Actions
  • declare variables with more descriptive names (third and fifth is no good)

@garazdawi
Copy link
Contributor

It would also be good to add tests for this feature.

@paulo-ferraz-oliveira
Copy link
Contributor Author

would also be good to add tests for this feature.

I'll add that to the TODO list, thanks.

jadeallenx
jadeallenx reviewed Sep 21, 2022
View reviewed changes
kerl Outdated Show resolved Hide resolved
@paulo-ferraz-oliveira paulo-ferraz-oliveira mentioned this pull request Nov 15, 2022
Merged
9 tasks
@paulo-ferraz-oliveira
Copy link
Contributor Author

Force pushing to rebase on top of master...

@paulo-ferraz-oliveira
Copy link
Contributor Author

paulo-ferraz-oliveira commented Nov 23, 2022 •
edited
Loading

Force-pushed to rebase onto master (in order to include GitHub Actions -based tests).

Edit: only missing the shell completion elements now. Completions are done, but tests are failing for the newly added feature.

@paulo-ferraz-oliveira
Copy link
Contributor Author

I've no idea why this is breaking in Actions. Locally it works, but I may have some difference in state (?). @jadeallenx, would you be able to help me here? Thank you.

@jadeallenx
Copy link
Collaborator

Sorry I've lost the thread on this - is the CI busted still?

@paulo-ferraz-oliveira
Copy link
Contributor Author

Hey. It is yeah, sorry. Haven't gotten around to this.

@paulo-ferraz-oliveira
Copy link
Contributor Author

paulo-ferraz-oliveira commented Apr 20, 2023 •
edited
Loading

Trying to get this into shape again:

  • 94aa6bb - update CI to remove a warning
  • b5d44a5 - act on CI results to fix the feature implementation

@jadeallenx
Copy link
Collaborator

C'mon CI hamsters 🐹

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as draft April 21, 2023 01:26
@paulo-ferraz-oliveira
Copy link
Contributor Author

I'll convert this back to Ready for review when tests are passing. 👍

@paulo-ferraz-oliveira
Copy link
Contributor Author

I'm closer to finishing. Have to look closer at how path works, since that's where it's failing now.

@paulo-ferraz-oliveira
Implement build-install
1ef5e91 
I'm still missing the bash and zsh completions
@paulo-ferraz-oliveira
Add tests
055f3f7
@paulo-ferraz-oliveira
Update bash-completion
838940d 
When you type

  kerl build-install <tab><tab>

this'll suggest from the list of releases

It won't do anything if you type

  kerl build-install git <tab><tab>
@paulo-ferraz-oliveira
Update zsh-completion
b827684 
When you type

  kerl build-install <tab><tab>

this'll suggest from the list of releases

It won't do anything if you type

  kerl build-install git <tab><tab>
@paulo-ferraz-oliveira
Update CI to remove set-output -related warning
536bfd1
@paulo-ferraz-oliveira
Tweak as per CI results
65c795d
@paulo-ferraz-oliveira
Copy link
Contributor Author

Hurrah, it's working. I'll still prefer to rebase this on top of #444, once that gets merged to master, for "All ✅".

Moving to Ready for review...

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review May 8, 2023 23:53
@jadeallenx jadeallenx merged commit 5660908 into kerl:master May 9, 2023
@jadeallenx
Copy link
Collaborator

fantastic thanks - i know it's taken a long time to get it merged

@paulo-ferraz-oliveira
Copy link
Contributor Author

Thanks much. We now have ✅ in master so everything's good 😄

@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/build-install branch May 9, 2023 18:31
@paulo-ferraz-oliveira paulo-ferraz-oliveira mentioned this pull request Dec 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadeallenx jadeallenx jadeallenx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify installation process
3 participants
@paulo-ferraz-oliveira @garazdawi @jadeallenx