Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoclean on build failure #410

Merged
merged 6 commits into from
Apr 18, 2023

Conversation

crownedgrouse
Copy link
Contributor

Configured by KERL_AUTOCLEAN variable (enabled by default).
Remove all build artefacts but logfile on failure if enabled.
This allow safe several attempts to build a release.

Logfile receive a banner for all build attempt with build variable at this time.

Fix #262

	Variable to configure behavior on build failure
	Set to 1 : clean build artefacts but logfile on failure
	Set to 0 : keep build artefacts
	Configured by KERL_AUTOCLEAN variable (enabled by default).
	Remove build artefacts but logfile on failure if enabled.
	This allow safe several attempts to build a release.

	Add a start banner of build attempt to logfile, with
	KERL_BUILD_* variable at the time
@jadeallenx
Copy link
Collaborator

We need to consolidate the steps for a failed build into a function like _handle_build_failure() which would:

  • show the log file extract
  • do an autoclean (if configured)
  • exit with an appropriate exit status

This would also make it easy/cleaner to include new post failure cleanup in the future.

@crownedgrouse
Copy link
Contributor Author

Not sure to understand what you expect me to do, then.

@jadeallenx
Copy link
Collaborator

Not sure to understand what you expect me to do, then.

Sorry, I didn't mean specifically for you to do this, just a clean up I'd like to do which is related to this PR.

@jadeallenx jadeallenx merged commit f846424 into kerl:master Apr 18, 2023
@jadeallenx
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kerl cleanup doesn't seem to work as described
2 participants