Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the process of rewriting the tags #1

Merged
merged 3 commits into from
Nov 29, 2012
Merged

Conversation

studio3104
Copy link

Hi.

I made ​​a fix to suppress the infinite loop.
I have been rewriting the tag implementation.

Thank you confirmation.

@@ -5,11 +5,28 @@ class FlattenOutput < Output
class Error < StandardError; end

Fluent::Plugin.register_output('flatten', self)

include Fluent::HandleTagNameMixin
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

個人的な好みですが、class FlattenOutput < Output直下にある方が好きです。

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あと、そのmixin使うなら、Gemfileに依存追加しないとならないですね。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fluent::HandleTagNameMixin is a part of fluentd's lib/fluent/mixin.rb

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

お、そうだったんですね。Thanks!!1

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fluentのversionいつから入ったんだろう。
ここからか fluent/fluentd@7f1fa6b

@kentaro
Copy link
Owner

kentaro commented Nov 29, 2012

Great pr!!1 Please add some code to test tag to be changed.

@mizzy
Copy link

mizzy commented Nov 29, 2012

👍

@@ -14,6 +14,7 @@ When you have a config as below:
<match test.**>
type flatten
key foo
add_tag_prefix flattened
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

タグの件についてドキュメントに追加する> @kentaro

@studio3104
Copy link
Author

テストを追加しました。
ご指摘いただいた点も修正しましたのでご確認願います。

よろしくお願いいたしますm(__)m

kentaro added a commit that referenced this pull request Nov 29, 2012
Add the process of rewriting the tags
@kentaro kentaro merged commit 16a608b into kentaro:master Nov 29, 2012
@kentaro
Copy link
Owner

kentaro commented Nov 29, 2012

Merged! Thanks!!!!!!!!!!!!!!!!!!!!!!!111

@lamanotrama
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants