-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the process of rewriting the tags #1
Conversation
@@ -5,11 +5,28 @@ class FlattenOutput < Output | |||
class Error < StandardError; end | |||
|
|||
Fluent::Plugin.register_output('flatten', self) | |||
|
|||
include Fluent::HandleTagNameMixin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
個人的な好みですが、class FlattenOutput < Output
直下にある方が好きです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あと、そのmixin使うなら、Gemfileに依存追加しないとならないですね。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fluent::HandleTagNameMixin is a part of fluentd's lib/fluent/mixin.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
お、そうだったんですね。Thanks!!1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fluentのversionいつから入ったんだろう。
ここからか fluent/fluentd@7f1fa6b
Great pr!!1 Please add some code to test tag to be changed. |
👍 |
@@ -14,6 +14,7 @@ When you have a config as below: | |||
<match test.**> | |||
type flatten | |||
key foo | |||
add_tag_prefix flattened |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
タグの件についてドキュメントに追加する> @kentaro
テストを追加しました。 よろしくお願いいたしますm(__)m |
Add the process of rewriting the tags
Merged! Thanks!!!!!!!!!!!!!!!!!!!!!!!111 |
👍 |
Hi.
I made a fix to suppress the infinite loop.
I have been rewriting the tag implementation.
Thank you confirmation.