Add support for custom password change forms #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
approved these changes
Nov 10, 2024
Three default fields: current password, new password, repeat new password. Actually, I should change that to |
|
Gtg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
kpxcFormfor handling pages where possible change password forms are not actuallyformelements, but three different input fields, and the submit button might not even be related to the same container.If the new
kpxcForm.initCustomForm()detects three different password fields and there's a form submit button exception found inkpxcSites, the fields are stored temporarily and the extension listens for the submit button click.Refactors
kpxcForm.onSubmit()to have multiple smaller functions that the newonCustomFormSubmit()can also use:activateCredentialBanner()handles the form field results and activates the Credential Banner. Originall this code was at the end ofonSubmit().getUsernameValue()returns the username value from selected input field or from retrieved credentials. Originally this code was at the middle ofonSubmit().Fixes an issue mentioned in: #1358 (comment)