Add support for draggable banners #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works well but the banner showed up on the top of the page immediately after a refresh (ie, the banner being dragged to the bottom is not remembered) |
The original idea was that this dragging is just temporary and done when it's needed. Of course we could just remember the state or add a separate option for remembering it. What do you think? |
|
Keep the drag, its a neat shortcut. We should remember the "last used state" though. |
|
Added a setting so the position will be remembered even after browser restart. |
droidmonkey
reviewed
Oct 7, 2024
droidmonkey
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a grab cursor when hovering on Credential or Custom Login Field banner, and allows user to move it to the bottom, or back to the top. If the credential or group selection dialog is open while dragging, its position is changed as well.
Known issues:
The dragging animation is not visible if dragging is canceled, or dragged to the same position where the banner already is. I couldn't find a reliable way to do that. The best solution was to disable the animation for good.
Banner on top (default):
Banner on bottom (after dragging):
Fixes #2327.