Skip to content

Commit

Permalink
Adjust the TOTP ignore regex
Browse files Browse the repository at this point in the history
  • Loading branch information
varjolintu committed Nov 2, 2024
1 parent 392fe2e commit 9fd21aa
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion keepassxc-browser/content/totp-field.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

const ignoreRegex = /(bank|coupon|postal|user|zip).*code|comment|author|error/i;
const ignoreRegex = /(bank|coupon|postal|user|zip).*code|(en|de)code(d|r)*|comment|author|error/i;
const ignoredTypes = [ 'email', 'password', 'username' ];

const acceptedOTPFields = [
Expand Down
4 changes: 4 additions & 0 deletions tests/tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ async function testTotpFields() {
[ '', { id: '2fa', type: 'text', maxLength: '6' }, 'Generic 2FA field', true ],
[ '', { id: '2fa', type: 'text', maxLength: '4' }, 'Ignore if field maxLength too small', false ],
[ '', { id: '2fa', type: 'text', maxLength: '12' }, 'Ignore if field maxLength too long', false ],
[ '', { id: 'encode', type: 'text', }, 'encode id is not acceptable', false ],
[ '', { id: 'encodedText', type: 'text', }, 'encodedText is not acceptable', false ],
[ '', { id: 'decoder', type: 'text', }, 'decoder id is not acceptable', false ],
[ '', { id: 'code', type: 'text', }, 'code id is accepted', true ],
[ '', { id: '2fa', type: 'text', maxLength: '12', autocomplete: 'one-time-code' }, 'Accept if one-time-code', true ],
[ '', { id: 'username', type: 'text', }, 'Ignore a generic input field', false ],
[ '', { type: 'password', }, 'Ignore a password input field', false ],
Expand Down

0 comments on commit 9fd21aa

Please sign in to comment.