Feat: Provide filtering capabilities for scalers #1400
Conversation
Signed-off-by: thisisobate <[email protected]>
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: thisisobate <[email protected]>
|
cc: @tomkerkhove |
|
I was waiting with reviewing because there was a TODO :) Doing that now! |
|
This takes up a big chunck of the scaler area: Can we move the filter on top with a drop down or so? Any thoughts @kedacore/keda-maintainers? |
This is because bulma spacing selectors automatically allocate that much space for columns. I can try using vanilla css instead to reduce the spacing so the scaler cards can fit comfortably. |
Signed-off-by: thisisobate <[email protected]>
|
@tomkerkhove any updates on this? |
|
No not for now, but I don't think this should block this PR, does it? If you share how I can add new categories seperately then that is OK for me. |
|
Btw, can we align the external vs built-in filter in to this new model please? Now we have 2 flavors |
I agree. It doesn't block it. In that case, I think we should merge and close this issue. |
We need to do this first though |
What exactly do you mean? The "maintainer" filter option already supports the built-in and external scalers. E.g, to filter the maintainer "JensWalter", you need to switch to the If you are saying we should add a new "built-in scaler" and "external scaler" filter options in the new filter pane, then I don't think that would work. Moreover, I don't think it's necessary given we already designed the ux and data architecture to work for the existing UI structure. |
I tend to disagree though, we currently have 2 UX for filtering scalers which is confusing. Certainly if we'll start adding more filters |
You have a point. If we must go the route you suggest, then it would warrant a complete overhaul of the data architecture which is an additional workload and frankly, it's slightly out of scope. I will have to discuss with @nate-double-u internally and see what we can do about this. In the meantime, I would advise you open a new issue for this request. Thank you! |
|
Let's keep this open, it's better to keep the current experience rather than introducing two different UXes. Why would this alignment cause a complete data architecture overhaul? |
|
Why would this alignment cause a complete data architecture overhaul?
Because for this to work, we would have to generate one central
datastore/index to query both in-built and external scalers which might be
tricky to solve.
We can keep this open. I will try and see if I can get something working;
will keep you posted.
cc: @nate-double-u
…On Wed, 5 Jun 2024 at 21:32, Tom Kerkhove ***@***.***> wrote:
Let's keep this open, it's better to keep the current experience rather
than introducing two different UXes.
Why would this alignment cause a complete data architecture overhaul?
—
Reply to this email directly, view it on GitHub
<#1400 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHBQHRXKJ5YRLR6HN6PHRG3ZF5YUVAVCNFSM6AAAAABINFZK7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQHEYTIOJVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Signed-off-by: thisisobate <[email protected]>
|
@tomkerkhove PTAL |
|
A lot better, thank you!
One last ask: Can we change the order so that we show, "Type", "Category", "Maintainer" please? |
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
|
@tomkerkhove I think we're good to go 😀 |
|
Thank you! |
* Feat: Provide filtering capabilities for scalers Signed-off-by: thisisobate <[email protected]> * chore: provide filter button on mobile Signed-off-by: thisisobate <[email protected]> * chore: reduce spacing between filter and scaler cards Signed-off-by: thisisobate <[email protected]> * chore: improve filter logic to use new model Signed-off-by: thisisobate <[email protected]> * chore: reorder filter options Signed-off-by: thisisobate <[email protected]> * chore: nit fix Signed-off-by: thisisobate <[email protected]> --------- Signed-off-by: thisisobate <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Ranjith Gopal <[email protected]>
* Feat: Provide filtering capabilities for scalers Signed-off-by: thisisobate <[email protected]> * chore: provide filter button on mobile Signed-off-by: thisisobate <[email protected]> * chore: reduce spacing between filter and scaler cards Signed-off-by: thisisobate <[email protected]> * chore: improve filter logic to use new model Signed-off-by: thisisobate <[email protected]> * chore: reorder filter options Signed-off-by: thisisobate <[email protected]> * chore: nit fix Signed-off-by: thisisobate <[email protected]> --------- Signed-off-by: thisisobate <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: shubhusion <[email protected]>
* Feat: Provide filtering capabilities for scalers Signed-off-by: thisisobate <[email protected]> * chore: provide filter button on mobile Signed-off-by: thisisobate <[email protected]> * chore: reduce spacing between filter and scaler cards Signed-off-by: thisisobate <[email protected]> * chore: improve filter logic to use new model Signed-off-by: thisisobate <[email protected]> * chore: reorder filter options Signed-off-by: thisisobate <[email protected]> * chore: nit fix Signed-off-by: thisisobate <[email protected]> --------- Signed-off-by: thisisobate <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]>
Todo
Relates to #412