Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Reference section, Glossary, removed non-inclusive language. #1389

Merged
merged 41 commits into from
Jun 28, 2024

Conversation

dwelsch-esi
Copy link
Contributor

@dwelsch-esi dwelsch-esi commented May 10, 2024

#1366
#1367
#1373

Umbrella issue for CNCF tech docs recommendations: #1361

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

  - Moved some content from KEDA concept topics to Reference.
- Added a glossary, issue kedacore#1367
- Removed non-inclusive language, issue kedacore#1373

kedacore#1366
kedacore#1367
kedacore#1373

Umbrella issue for CNCF tech docs recommendations:
kedacore#1361

Signed-off-by: David Welsch <[email protected]>
@dwelsch-esi dwelsch-esi requested a review from a team as a code owner May 10, 2024 21:35
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented May 10, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit b59f045
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/667eb52c432edd0008c2823c
😎 Deploy Preview https://deploy-preview-1389--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomkerkhove
Copy link
Member

Hey, mind fixing the build issue?

Thanks for opening the PR!

@nate-double-u
Copy link
Contributor

I've taken a pass at fixing the build errors over on dwelsch-esi#1 @dwelsch-esi, i'm not sure that this PR introduced all of the broken links though. Regardless, I hope the PR into your fork fixes them 🙂

@tomkerkhove
Copy link
Member

Thank you!

nate-double-u and others added 23 commits May 30, 2024 13:51
* formatting tables

removing broken links

correcting typos

correcting link

formatting table

fixing links

Signed-off-by: Nate W <[email protected]>

* Update content/docs/2.15/operate/_index.md

Signed-off-by: Dave Welsch <[email protected]>

---------

Signed-off-by: Nate W <[email protected]>
Signed-off-by: Dave Welsch <[email protected]>
Co-authored-by: Dave Welsch <[email protected]>
Fixed reference to scaledobject file moved from concepts to reference.

Signed-off-by: Dave Welsch <[email protected]>
Fixed references to moved content.

Signed-off-by: Dave Welsch <[email protected]>
Signed-off-by: Dave Welsch <[email protected]>
  - Moved some content from KEDA concept topics to Reference.
- Added a glossary, issue kedacore#1367
- Removed non-inclusive language, issue kedacore#1373

kedacore#1366
kedacore#1367
kedacore#1373

Umbrella issue for CNCF tech docs recommendations:
kedacore#1361

Signed-off-by: David Welsch <[email protected]>
* formatting tables

removing broken links

correcting typos

correcting link

formatting table

fixing links

Signed-off-by: Nate W <[email protected]>

* Update content/docs/2.15/operate/_index.md

Signed-off-by: Dave Welsch <[email protected]>

---------

Signed-off-by: Nate W <[email protected]>
Signed-off-by: Dave Welsch <[email protected]>
Co-authored-by: Dave Welsch <[email protected]>
Fixed reference to scaledobject file moved from concepts to reference.

Signed-off-by: Dave Welsch <[email protected]>
Fixed references to moved content.

Signed-off-by: Dave Welsch <[email protected]>
dwelsch-esi and others added 2 commits June 23, 2024 19:23
content/docs/2.14/reference/_index.md Outdated Show resolved Hide resolved
content/docs/2.14/reference/_index.md Outdated Show resolved Hide resolved
content/docs/2.14/reference/_index.md Outdated Show resolved Hide resolved
content/docs/2.15/reference/_index.md Outdated Show resolved Hide resolved
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Dave Welsch <[email protected]>
Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, the content is ready to go in now, and any further updates that might be needed are small enough to manage in follow up PRs.

I recommend a squash on merge in this case.

@tomkerkhove
Copy link
Member

Thanks, I agree but wanted to hear from @zroubalik or @JorTurFer first

@tomkerkhove tomkerkhove merged commit a412049 into kedacore:main Jun 28, 2024
8 checks passed
@tomkerkhove
Copy link
Member

Thanks @dwelsch-esi!

SpiritZhou pushed a commit to SpiritZhou/keda-docs that referenced this pull request Jul 11, 2024
…edacore#1389)

Co-authored-by: Dave Welsch <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Co-authored-by: Nate W <[email protected]>
Co-authored-by: thisisobate <[email protected]>
shubhusion pushed a commit to shubhusion/keda-docs that referenced this pull request Aug 5, 2024
…edacore#1389)

Co-authored-by: Dave Welsch <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Co-authored-by: Nate W <[email protected]>
Co-authored-by: thisisobate <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants