add: enable webhook patching with flag #6396
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrishnaSindhur
force-pushed
the
webhook-flag
branch
from
26bbc4e
to
bc4db15
Compare
Signed-off-by: krishna sindhur <[email protected]>
KrishnaSindhur
force-pushed
the
webhook-flag
branch
from
bc4db15
to
5877362
Compare
JorTurFer
reviewed
Dec 2, 2024
Comment on lines
+66
to
+69
| { | ||
| Name: cm.APIServiceName, | ||
| Type: rotator.APIService, | ||
| }, |
There was a problem hiding this comment.
This new flag should enable/disable only the webhook, the apiservice has to be patched always when the patcher is active (managed by the flag --enable-cert-rotation=true). This new feature should be a fine grain configuration to disable the webhook patching for installations where webhooks aren't deployed
|
Nice addition! I think that we should document it also as part of docs (maybe here) and support it in our helm chart (disabling the patching when the webhooks aren't deployed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a flag in the operator to the webhook patching
Checklist
Fixes #6184