Fix Graceful Shutdown of Interceptor and Scaler #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Tôrres <[email protected]>
Contributor
Author
tomkerkhove
reviewed
Jul 14, 2023
Member
tomkerkhove
left a comment
tomkerkhove
left a comment
There was a problem hiding this comment.
LGTM, but I'll leave it up to the expert
JorTurFer
approved these changes
Jul 14, 2023
Member
|
LGTM! We can merge the PR when @tomkerkhove 's comments are addressed |
Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Pedro Tôrres <[email protected]>
Contributor
Author
|
Done |
JorTurFer
pushed a commit
to JorTurFer/http-add-on
that referenced
this pull request
Jul 28, 2023
Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interceptor and Scaler will now gracefully shutdown on SIGINT and SIGTERM. It also patches shutdown routines to complete ongoing requests before closing connections.
Checklist
README.mddocs/directoryFixes #731