Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring up to par #2

Merged
merged 10 commits into from
Sep 11, 2024
Merged

Bring up to par #2

merged 10 commits into from
Sep 11, 2024

Conversation

LeipeLeon
Copy link
Member

@LeipeLeon LeipeLeon commented Sep 10, 2024 •
edited
Loading

Bring the project up to par:

  • Ruby 2.7
  • Github 🎬
  • 🐳
  • general tidying
  • basic passing specs

@LeipeLeon LeipeLeon force-pushed the bring_up_to_par branch 4 times, most recently from deca0a0 to dbef2b1 Compare September 10, 2024 11:03
@LeipeLeon
✨ Github 🎬
dfcda36 
Note: No effort will be taken to make it run on ruby 2.2
@LeipeLeon LeipeLeon marked this pull request as ready for review September 10, 2024 11:16
kjwierenga
kjwierenga approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@kjwierenga kjwierenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LeipeLeon LeipeLeon merged commit b6cfd5e into master Sep 11, 2024
6 checks passed
@LeipeLeon LeipeLeon deleted the bring_up_to_par branch September 11, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjwierenga kjwierenga kjwierenga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeipeLeon @kjwierenga