fix wrong notes for func GetSandboxesStoragePathRust()#6355
Merged
cmaf merged 1 commit intokata-containers:mainfrom Mar 3, 2023
yanggangtony:fix-wrong-notes
Merged
fix wrong notes for func GetSandboxesStoragePathRust()#6355cmaf merged 1 commit intokata-containers:mainfrom yanggangtony:fix-wrong-notes
cmaf merged 1 commit intokata-containers:mainfrom
yanggangtony:fix-wrong-notes
Conversation
Contributor
|
Can one of the admins verify this patch? |
Tim-0731-Hzt
approved these changes
Feb 23, 2023
Member
|
Thank you @yanggangtony , before this PR being merged, you need fix your commit message https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format |
liubin
approved these changes
Feb 27, 2023
Contributor
Author
|
@liubin |
Member
|
@yanggangtony, you need to raise an issue for this PR, and add Fixes:#XXX in the commit |
Fix wrong notes for func GetSandboxesStoragePathRust() Fixes: #6394 Signed-off-by: yanggang <[email protected]>
Contributor
Author
|
@Tim-0731-Hzt |
Closed
cmaf
approved these changes
Mar 2, 2023
|
/test |
Member
|
@cmaf It looks like the jenkins-ci-s390x-unit-ubuntu-20-04 job completed several hours ago, but somehow github did not see it, so I cannot merge this. What is the procedure in that case? |
Member
|
/test-s390x-unit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix wrong notes for func GetSandboxesStoragePathRust()