Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Launcher does not clean up sigkill timeout #946

Closed
vojtajina opened this issue Mar 11, 2014 · 0 comments · Fixed by #1054
Closed

Process Launcher does not clean up sigkill timeout #946

vojtajina opened this issue Mar 11, 2014 · 0 comments · Fixed by #1054
Assignees
Milestone

Comments

@vojtajina
Copy link
Contributor

When killing a browser, the sigkill timeout has to be cleared in _onProcessExit.

@vojtajina vojtajina added this to the v0.14 milestone Mar 11, 2014
@pkozlowski-opensource pkozlowski-opensource self-assigned this Apr 25, 2014
pkozlowski-opensource added a commit to pkozlowski-opensource/karma that referenced this issue Apr 30, 2014
By default browsers are killed with `process.kill()` but it might
happen that a process doesn't play nicelly and doesn't exit so
there is a timeout after which a process is SIGKILL-ed. Before
this commit the mentioned timeout wasn't cleared on clean process
exit, preventing Karma from exiting just after all tests were run.

Fixes karma-runner#946
pkozlowski-opensource added a commit to pkozlowski-opensource/karma that referenced this issue May 1, 2014
By default browsers are killed with `process.kill()` but it might
happen that a process doesn't play nicelly and doesn't exit so
there is a timeout after which a process is SIGKILL-ed. Before
this commit the mentioned timeout wasn't cleared on clean process
exit, preventing Karma from exiting just after all tests were run.

Fixes karma-runner#946
pkozlowski-opensource added a commit to pkozlowski-opensource/karma that referenced this issue May 8, 2014
By default browsers are killed with `process.kill()` but it might
happen that a process doesn't play nicelly and doesn't exit so
there is a timeout after which a process is SIGKILL-ed. Before
this commit the mentioned timeout wasn't cleared on clean process
exit, preventing Karma from exiting just after all tests were run.

Fixes karma-runner#946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants