-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw an error on not found browsers #855
Throw an error on not found browsers #855
Comments
I agree. |
missing anything should fail (cannot load):
Show all errors and fail (not fail on first error). |
This is related to #1011 |
@jnewman where is this error coming from? The |
@vojtajina I thought the issue was related this, I was mistaken. (It's concurrent processes on our CI, but I thought the conflict was from karma; it's not.) |
Fail out of karma if a launcher, reporter, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. This is a WIP: I can't quite figure out where to place a final check on whether any errors were caught while loading launchers, reporters, or preprocessors. Any quick tip would be much appreciated! Closes karma-runner#855
Fail out of karma if a launcher, reporter, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. Closes karma-runner#855
@budde377 mind taking a look at this? This is the last thing I want to get in that isn't PRed yet before finally moving to 1.0 and using proper semver. |
@dignifiedquire Will do! |
Fail out of karma if a launcher, reporter, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. Closes karma-runner#855
Fail out of karma if a launcher, reporter, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. Closes karma-runner#855
…ors. Stop karma if a launcher, reporter, plugin, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. Closes karma-runner#855
…ors. Stop karma if a launcher, reporter, plugin, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. Closes karma-runner#855
…ors. Stop karma if a launcher, reporter, plugin, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. Closes karma-runner#855
…ors. Stop karma if a launcher, reporter, plugin, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. Closes karma-runner#855
…ors. Stop karma if a launcher, reporter, plugin, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. Closes karma-runner#855
…ors. Stop karma if a launcher, reporter, plugin, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. Closes karma-runner#855
…ors. Stop karma if a launcher, reporter, plugin, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. Closes karma-runner#855
…ors. Stop karma if a launcher, reporter, plugin, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. Closes karma-runner#855
…ors. Stop karma if a launcher, reporter, plugin, or preprocessor fails to load, after attempting to load each of them, and reporting errors for each load error. Closes karma-runner#855
Currently, it looks like if a browser isn't able to be loaded, karma just warns you and happily proceeds with the browsers that could be loaded.
https://github.com/karma-runner/karma/blob/master/lib/launcher.js#L41-L46
In a CI environment, it would be really, really easy to overlook that all of the sudden one of your configured browsers isn't working anymore, but since no errors are thrown the build is still happy.
I'm proposing that instead of continuing on, encountering a browser that couldn't be loaded should be treated as a fatal error - any loaded browsers should be cleaned up, and the process should exit.
The text was updated successfully, but these errors were encountered: