-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"watched: false" not being honored in config file. #616
Labels
Comments
@joakimkarlsson thanks for reporting this. I confirm this is a bug. chokidar does not watch patterns, but directories, therefore karma watches common parent directly of each pattern. We need to check the patterns inside "ignore" function (https://github.com/karma-runner/karma/blob/master/lib/watcher.js#L47). Because fileList does not care about watched/non watched (which is correct). |
joakimkarlsson
pushed a commit
to joakimkarlsson/karma
that referenced
this issue
Jul 4, 2013
Includes the patterns for files to include, but not to watch, in addition to the excludes list when creating a list of patterns to ignore. This makes the watcher ignore patterns marked as "watched: false" in karma's configuration file. Closes: karma-runner#616
vojtajina
added a commit
to vojtajina/karma
that referenced
this issue
Oct 21, 2013
This fix significantly improves watching performance. It tells chokidar to ignore all paths that do not match any of the watched patterns. Before we were only ignoring paths that match some of the excludes patterns. That means that even files that didn't match any of the watched patterns were still watched by chokidar and ignored on the level of `fileList`. Note, this fix requires paulmillr/chokidar#61. Closes karma-runner#616
vojtajina
added a commit
that referenced
this issue
Oct 21, 2013
This fix significantly improves watching performance. It tells chokidar to ignore all paths that do not match any of the watched patterns. Before we were only ignoring paths that match some of the excludes patterns. That means that even files that didn't match any of the watched patterns were still watched by chokidar and ignored on the level of `fileList`. Note, this fix requires chokidar 0.7.0 Closes #616
vojtajina
added a commit
that referenced
this issue
Oct 21, 2013
This fix significantly improves watching performance. It tells chokidar to ignore all paths that do not match any of the watched patterns. Before we were only ignoring paths that match some of the excludes patterns. That means that even files that didn't match any of the watched patterns were still watched by chokidar and ignored on the level of `fileList`. Note, this fix requires chokidar 0.7.0 Closes #616
vojtajina
added a commit
to vojtajina/karma
that referenced
this issue
Oct 22, 2013
This fix significantly improves watching performance. It tells chokidar to ignore all paths that do not match any of the watched patterns. Before we were only ignoring paths that match some of the excludes patterns. That means that even files that didn't match any of the watched patterns were still watched by chokidar and ignored on the level of `fileList`. Note, this fix requires chokidar 0.7.0 Closes karma-runner#616
This was referenced Sep 27, 2018
This was referenced May 25, 2019
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Karma version: 0.8.6
OS: Windows 7 64 bit
Consider the following structure of my project:
And the following karma.conf.js:
If I edit and save app/app.html while having karma watching my files, my tests will run even though the file pattern for html files states that the watcher should ignore them.
The text was updated successfully, but these errors were encountered: