-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-main.js in base directory is not watched #521
Comments
Can you share your full |
How about I just do this: https://github.com/jamestalmage/karma-issue-521 |
Updated the repo with clearer instructions to reproduce |
Woow, you are right, that was actually a bug! Thanks for very nice report, it was super easy to reproduce and debug with your example @jamestalmage ! It's fixed in master (and stable). Btw, it's better, if you server only chai module, so that the glob does not have to traverse your whole node_modules: files = [
// ...
{pattern: 'node_modules/chai/**/*.js', included:false, watched:false, served:true}
]; |
Thanks, glad to help! As for optimizing the pattern for glob, that makes sense. Even more so with require.js as Is there room for an additional file pattern option (maybe If the Maybe I am making things too difficult and we only need a simpler files = [
/// files that you want included and/or watched for changes and/or might be tests
];
servedDirs = [
'images',
'node_modules',
'bower_components'
]; |
The |
@vojtajina I'm a bit confused as to how to get the updated version. I've tried all the following:
tried I am obviously missing something. |
@jamestalmage sorry, you are not missing anything, I'm just stupid - I didn't push any release to npm since this change. Sorry I was very busy last month and didn't have any time for Karma. I will do it soon. |
@jamestalmage it's pushed in NPM, please update... |
Followed the Require.js example on the site, with the exception of putting
test-main.js
in the root directory of the project.karma.conf.js
includes it as followsTests will run correctly - but changes to
test-main.js
to not trigger a test run.Moving the file to
test/test-main.js
solves the issue. Tests rerun every time the file is changed.I tried other
included:true
files in the base directory (i.e. not the require.js config file), and they worked just fine. It does not appear to be related to it being an included file.I also changed the file name to
test-main-file.js
. That did not solve the issue. It does not appear to be any sort of name collision.Once, while renaming the file I did have karma still running, and it logged a notice that the file went missing.
With
logLevel = LOG_DEBUG
no log events are fired simply by changing the contents oftest-main.js
and saving.The text was updated successfully, but these errors were encountered: