Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking changes in dependency source-map #3557

Closed
puppe opened this issue Sep 3, 2020 · 4 comments · Fixed by karronoli/redpen#10 · May be fixed by PDSSnyk/juice-shop#74
Closed

Breaking changes in dependency source-map #3557

puppe opened this issue Sep 3, 2020 · 4 comments · Fixed by karronoli/redpen#10 · May be fixed by PDSSnyk/juice-shop#74

Comments

@puppe
Copy link

puppe commented Sep 3, 2020

As of commit 5db46b7, Karma uses version ^0.7.3 of source-map. Version 0.7.0 had introduced several breaking changes. At least one of those breaks error reporting in Karma when source maps are used:

Breaking change: new SourceMapConsumer now returns a Promise object
that resolves to the newly constructed SourceMapConsumer instance, rather
than returning the new instance immediately.

This invariably results in the following error message whenever a test fails:

SourceMap position not found for trace: …
@puppe
Copy link
Author

puppe commented Sep 3, 2020

PS: The exception is thrown here, when originalPositionFor is called because getSourceMapConsumer now returns a Promise of a SourceMapConsumer instead of a SourceMapConsumer.

@devoto13
Copy link
Collaborator

devoto13 commented Sep 3, 2020

Thanks for a report. Would you be willing to send a PR to rollback to a previous version of source-map as a temporary workaround?

@puppe puppe mentioned this issue Sep 3, 2020
Closed
@puppe
Copy link
Author

puppe commented Sep 3, 2020

No problem. See #3558.

devoto13 added a commit to devoto13/karma that referenced this issue Sep 3, 2020
@devoto13
fix: revert source-map update
af3919a 
As it contains a breaking change per karma-runner#3557.
@devoto13 devoto13 mentioned this issue Sep 3, 2020
Merged
johnjbarton pushed a commit that referenced this issue Sep 8, 2020
@devoto13
fix: revert source-map update (#3559)
d9ba284 
As it contains a breaking change per #3557.
karmarunnerbot pushed a commit that referenced this issue Sep 8, 2020
@semantic-release-bot
chore(release): 5.2.2 [skip ci]
fffbaee 
## [5.2.2](v5.2.1...v5.2.2) (2020-09-08)

### Bug Fixes

* revert source-map update ([#3559](#3559)) ([d9ba284](d9ba284)), closes [#3557](#3557)
@johnjbarton johnjbarton mentioned this issue Oct 19, 2020
Closed
@johnjbarton
Copy link
Contributor

Fixed by PR #3559

@karronoli karronoli mentioned this issue Aug 16, 2022
Merged
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this issue May 16, 2023
@devoto13 @anthony-redFox
fix: revert source-map update (karma-runner#3559)
f8a2e19 
As it contains a breaking change per karma-runner#3557.
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this issue May 16, 2023
@semantic-release-bot @anthony-redFox
chore(release): 5.2.2 [skip ci]
5a53a80 
## [5.2.2](karma-runner/karma@v5.2.1...v5.2.2) (2020-09-08)

### Bug Fixes

* revert source-map update ([karma-runner#3559](karma-runner#3559)) ([d9ba284](karma-runner@d9ba284)), closes [karma-runner#3557](karma-runner#3557)
@PDSSnyk PDSSnyk mentioned this issue Jun 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump karma from ~1.2.0 to ~6.4 in /redpen-server karronoli/redpen
[Snyk] Fix for 2 vulnerabilities PDSSnyk/juice-shop
3 participants
@johnjbarton @devoto13 @puppe