Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove support for node 6 #3246

Merged
merged 1 commit into from
Jan 1, 2019
Merged

chore: remove support for node 6 #3246

merged 1 commit into from
Jan 1, 2019

Conversation

lusarz
Copy link
Contributor

@lusarz lusarz commented Dec 30, 2018

This pull request remove support for node v6.

Let me know if I missed something here ...

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe the breaking change (and our reasons):
http://karma-runner.github.io/3.0/dev/git-commit-msg.html

We also need to have a similar change to the integration-tests project, and land it before any async changes.

@lusarz lusarz changed the title fix(config): remove support for node v6 chore: remove support for node 6 Dec 31, 2018
@lusarz
Copy link
Contributor Author

lusarz commented Dec 31, 2018

@johnjbarton Thank you, I've updated commit message.

What you mean by "integration-tests project" ?

@johnjbarton
Copy link
Contributor

The karma-runner integration tests (tests with plugins) are configured here:
https://github.com/karma-runner/integration-tests/blob/master/.travis.yml
and pulled into the test run via
https://github.com/karma-runner/karma/blob/master/scripts/integration-tests.sh

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a documentation line:

https://github.com/karma-runner/karma/blob/f71da205d779e208fcd4bdbcc9e9b35f93994d1f/docs/intro/04-faq.md#which-version-of-nodejs-does-karma-run-with

Maybe we can replace That is 6.x, 8.x and 10.x at this point. with something that acknowledges the version dependency. You may need to install older versions of karma-runner if you must support older versions of nodejs. For example, to run on nodejs 6.x, install karma-runner 3.x. Then in future we can just leave this doc file as is.

@lusarz
Copy link
Contributor Author

lusarz commented Jan 1, 2019

I created pull request on integration-tests project:
karma-runner/integration-tests#10

Yeah, it would be nice to update this documentation line - do you have proposition for whole section ? Because currently it contains Karma works on all LTS versions , which would not be true after this pull request merge.

@johnjbarton
Copy link
Contributor

Karma works on all LTS versions node in active maintenance state (see LTS docs for more info) as well as the latest stable version. That is 6.x, 8.x and 10.x at this point.

to eg:

Karma is tested on (at least) the active LTS versions of node as specified by the
Node.js Release Working Group. The nodejs version numbers are set in the package.json. Older versions of karma work with older versions of nodejs, but these older versions are not maintained or updated.

@lusarz
Copy link
Contributor Author

lusarz commented Jan 1, 2019

Okay, I updated this info in docs.

Set node 8 as minimal supported version.

Closes #3151
BREAKING CHANGE:
Drop Support for Node 6, to make it possible to use async/await in karma codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants