-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for async/await in karma code #3151
Support for async/await in karma code #3151
Comments
Personally I would like to see the node-v4-level updates completed first, like Somewhat related but perhaps more difficult: a way to support existing plugins but also allow asynchronous plugins would be cool. |
Ok, it sounds good to me |
@johnjbarton, if one wanted to work on the node v4 level updates, is there anywhere you would recommend to start? |
We're actually pretty close to the finish line. Look for files with |
@johnjbarton, am I right in thinking that both |
Looks like @lusarz got them all huh? |
@johnjbarton yeah, now I'm waiting for green light to introduce async/await ;) @jniles Some times ago I've did some research about possibility to replace |
If we add |
What about forcing users to use node >=8 and forget about karma releases with node 6 support at all ? Are there some use cases when it may not be possible (migrating to node >=8) ? |
Yes, I assumed we would drop node v6. So our story could be "Sorry, if you want to use node v6 after 3.1.2, you have to fork the source". I just want to make a clear decision, not an accident and no implied support for two versions at the same time. |
Yes, I agree with that. |
v3.1.4 seems stable, let's call that the last node 6 version and move on to v4 w/node 8 and async. |
What do you thinks about using async/await in our code. It is natively supported from
Node 8
, butNode 6
is now in maintenance, and it's end of life is planned to April 2019.We can consider remove karma support for Node 6 now, or adapt puppeteer solution.
The text was updated successfully, but these errors were encountered: