Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): Upgrade to log4js 2.x API. #2868

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

johnjbarton
Copy link
Contributor

Support log4js 2.x as well as 1.x for configuration.

Fixes #2858

Support log4js 2.x as well as 1.x for configuration.

Fixes karma-runner#2858
Copy link
Contributor

@zzo zzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like madness to me but if tests pass I'm game

@johnjbarton johnjbarton merged commit f6f8707 into karma-runner:master Nov 21, 2017
@johnjbarton
Copy link
Contributor Author

In a 2.0 we can delete the backcompat goop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants