Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Update to support log4js version 2. #2858

Closed
johnjbarton opened this issue Oct 25, 2017 · 0 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

[chore] Update to support log4js version 2. #2858

johnjbarton opened this issue Oct 25, 2017 · 0 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Assignees
@johnjbarton
Labels
type: chore

Comments

@johnjbarton
Copy link
Contributor

Expected behaviour

Works with modern "log4js"

Actual behaviour

Fails with 2.3.9 because setGlobalLogLevel is no longer part of the log4js API

Environment Details

  • Karma version 1.7.1
  • Relevant part of your karma.config.js file
    Not

Steps to reproduce the behaviour

  1. Update package.json to use log4js "^2.3.9"
@johnjbarton johnjbarton self-assigned this Oct 25, 2017
johnjbarton added a commit to johnjbarton/karma that referenced this issue Nov 2, 2017
@johnjbarton
fix(logging): Upgrade to log4js 2.x API.
65a5117 
Support log4js 2.x as well as 1.x for configuration.

Fixes karma-runner#2858
@johnjbarton johnjbarton mentioned this issue Nov 2, 2017
Merged
johnjbarton added a commit that referenced this issue Nov 21, 2017
@johnjbarton
fix(logging): Upgrade to log4js 2.x API. (#2868)
f6f8707 
Support log4js 2.x as well as 1.x for configuration.

Fixes #2858
@karronoli karronoli mentioned this issue Aug 16, 2022
Merged
@Omrisnyk Omrisnyk mentioned this issue Oct 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnjbarton johnjbarton

Labels
type: chore
Projects
None yet
Milestone
No milestone
1 participant
@johnjbarton