Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Karma calls Jasmine twice. #2799

Open
hpufo opened this issue Aug 5, 2017 · 2 comments
Open

Karma calls Jasmine twice. #2799

hpufo opened this issue Aug 5, 2017 · 2 comments
Labels
needs: feedback-from-author

Comments

@hpufo
Copy link

hpufo commented Aug 5, 2017 •
edited
Loading

Expected behaviour

Karma calls jasmine tests once.

Actual behaviour

Everything in the describe and it functions are being called twice, causing some tests to fail.

Environment Details

I also tried this but the result was the same(If I set included to false, karma breaks):
files: [ { pattern: 'test/**/*.tsx', watched: false, served: true, included: true } ],

Steps to reproduce the behaviour

  1. I run karma start from the console
  2. Everything in the describe and it functions are called twice.
  3. Tests that calls helper functions calls it twice resulting in the wrong return and test failing

I have created a simple mock to display this problem:

function fillArray(len: number) {
  const array = new Array(len);
  for (let i = 0; i < len; i++) {
    array.push(0);
  }
  return array;
}
describe('Karma', () => {
  console.log('DESCRIBE');
  it('runs a test and prints', () => {
    const array = fillArray(1);
    console.log(array.length);
    expect(true).toBe(true);
  });
});

Here is what the above outputs in my console(I am only including the interesting parts):
image
@EzraBrooks
Copy link
Collaborator

I haven't experienced this issue with a similar setup on the most recent version from master. Are you still experiencing this issue?

@is-already-taken
Copy link
Contributor

I can reproduce this issue with the Karma API. Karma 4.0.1, Karma-Chrome-Launcher 2.2.0.

See the MCVE for a bare minimum example: https://github.com/is-already-taken/karma-runs-twice-mcve

is-already-taken added a commit to is-already-taken/karma that referenced this issue Mar 18, 2019
@is-already-taken
feat(runner): Config option to prevent logging to the console twice
3f5e235 
This might be the case when Karma.run() is called inside the same
process/terminal as the server is running in (e.g. development
servers).

Fixes karma-runner#2121, karma-runner#2799
is-already-taken added a commit to is-already-taken/karma that referenced this issue Mar 18, 2019
@is-already-taken
feat(runner): Config option to prevent logging to the console twice
a9d8c71 
This might be the case when Karma.run() is called inside the same
process/terminal as the server is running in (e.g. development
servers).

Fixes karma-runner#2121, karma-runner#2799
is-already-taken added a commit to is-already-taken/karma that referenced this issue Mar 18, 2019
@is-already-taken
feat(runner): Config option to prevent logging to the console twice
0142408 
This might be the case when Karma.run() is called inside the same
process/terminal as the server is running in (e.g. development
servers).

Fixes karma-runner#2121, karma-runner#2799
@is-already-taken is-already-taken mentioned this issue Mar 18, 2019
Merged
is-already-taken added a commit to is-already-taken/karma that referenced this issue Mar 30, 2019
@is-already-taken
feat(runner): Config option to prevent logging to the console twice
a7579dc 
This might be the case when Karma.run() is called inside the same
process/terminal as the server is running in (e.g. development
servers).

Fixes karma-runner#2121, karma-runner#2799
is-already-taken added a commit to is-already-taken/karma that referenced this issue Apr 10, 2019
@is-already-taken
WIP feat(runner): Return emitter that forwards server data
5fca98e 
Allow the consumer to decide whether to echo the runner progress or not.

This might be the case when Karma.run() is called inside the same
process/terminal as the server is running in (e.g. development
servers).

Fixes karma-runner#2121, karma-runner#2799
is-already-taken added a commit to is-already-taken/karma that referenced this issue Apr 10, 2019
@is-already-taken
WIP feat(cli): Echo the runner progress event, don't echo in runner
8ebb5a7 
The CLI shall echo the progress, not the runner itself.

Fixes karma-runner#2121, karma-runner#2799
is-already-taken added a commit to is-already-taken/karma that referenced this issue Apr 10, 2019
@is-already-taken
feat(runner): Return emitter that forwards server data
ea0b9c4 
Allow the consumer to decide whether to echo the runner progress or not.

This might be the case when Karma.run() is called inside the same
process/terminal as the server is running in (e.g. development
servers).

Fixes karma-runner#2121, karma-runner#2799
is-already-taken added a commit to is-already-taken/karma that referenced this issue Apr 10, 2019
@is-already-taken
feat(cli): Echo the runner progress event, don't echo in runner
10b9833 
The CLI shall echo the progress, not the runner itself.

Fixes karma-runner#2121, karma-runner#2799
is-already-taken added a commit to is-already-taken/karma that referenced this issue Apr 11, 2019
@is-already-taken
feat(cli): Echo the runner progress event, don't echo in runner
cca8994 
The CLI shall echo the progress, not the runner itself.

Fixes karma-runner#2121, karma-runner#2799
johnjbarton pushed a commit that referenced this issue Jul 30, 2019
@is-already-taken @johnjbarton
feat(runner):
62d4c5a 
* feat(runner): Return emitter that forwards server data

Allow the consumer to decide whether to echo the runner progress or not.

This might be the case when Karma.run() is called inside the same
process/terminal as the server is running in (e.g. development
servers).

Fixes #2121, #2799

* feat(cli): Echo the runner progress event, don't echo in runner

The CLI shall echo the progress, not the runner itself.

Fixes #2121, #2799
@snyk-bot snyk-bot mentioned this issue Apr 12, 2020
Closed
@karronoli karronoli mentioned this issue Aug 16, 2022
Merged
@Omrisnyk Omrisnyk mentioned this issue Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs: feedback-from-author
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@is-already-taken @EzraBrooks @hpufo