Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE8 doesn't work since karma 0.13.0 #1529

Closed
dchambers opened this issue Jul 31, 2015 · 3 comments · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

IE8 doesn't work since karma 0.13.0 #1529

dchambers opened this issue Jul 31, 2015 · 3 comments · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Labels
help wanted priority: high type: bug

Comments

@dchambers
Copy link

IE8 stopped working since karma started using the dom-serialize library in karma 0.13.0. This is because Object.reduce is used on this line of code, but no shim has been provided for IE8.
@dignifiedquire
Copy link
Member

Thanks for the report.

@dchambers
Copy link
Author

Actually, karma 0.12.37 doesn't seem to work either because there is a file with a URL like http://localhost:9876/absolute/tmp/4a09ba9cdb71424e0ecb978e4c0a49ce.browserify that is served with the content type text/plain, which IE8 then refuses to load.

Is there an older version of karma that you would recommend for people still needing to test against IE8?

@dignifiedquire
Copy link
Member

The official policy is that all versions of Karma should support IE8, so I'm not sure at which point we broke this contract. If you are up to it, I would be happy to accept a PR fixing it, as I can only test against IE11 with simulated IE8 behaviour at the moment.

@dchambers dchambers mentioned this issue Jul 31, 2015
Closed
kketch pushed a commit to kketch/karma that referenced this issue Aug 4, 2015
Add core-js es5 shim to karma client, fixes karma-runner#1529
61fae8c
dignifiedquire added a commit that referenced this issue Aug 4, 2015
@dignifiedquire
Merge pull request #1535 from kketch/fix-karma-client-0.13.0-ie8
20f8259 
Add core-js es5 shim to karma client, fixes #1529
@Omrisnyk Omrisnyk mentioned this issue Oct 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted priority: high type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Fix for 2 vulnerabilities Omrisnyk/npm-lockfiles
[Snyk] Security upgrade karma from 2.0.3 to 3.0.0 Omrisnyk/npm-lockfiles
2 participants
@dchambers @dignifiedquire