-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: autoWatchBatchDelay option is being "ignored" #1520
bug: autoWatchBatchDelay option is being "ignored" #1520
Comments
I can't believe I did this mistake again, for some reason I'm never able to use |
Honestly, I wouldn't know how to write the tests :) |
@ferrarit there are actually tests https://github.com/karma-runner/karma/blob/master/test/unit/file-list.spec.coffee#L568-L639 which start failing when I introduce |
I have created a simple test here: https://github.com/ferrarit/karma-test
|
Thanks |
Thank you sir for the quick fix and the amazing job you are doing with Karma. 👍 |
Looks like my fix is not working yet :( Will revisit tomorrow with a fresh brain |
Any update on this? I have no experience in using either
EDIT I managed to fix the issue with this commit. It sets Any thoughts? |
Released in v0.13.5 |
Although this fixes the issue for short delays, If you use a longer delay (e.g. 1000), you'll get a That was why I suggested throttling the event after its first emission. |
autoWatchBatchDelay
options is irrelevant in current version of karmaThe problem seems to be caused by the use of
_.throttle
fabdbae#diff-e8e0621a959fd2639bcc23cd2601f67fR73
replacing
_.throttle
with_.debounce
fixes the issueThe text was updated successfully, but these errors were encountered: