-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static binary assets are not served correctly when they have capital letters in extension #1508
Closed
Labels
Comments
You can add a test here: karma/test/unit/preprocessor.spec.coffee Line 182 in 8a9c8c7
|
Current
|
You'll need to run these commands first https://github.com/karma-runner/karma/blob/master/.travis.yml#L23-L24 |
lonelyelk
added a commit
to lonelyelk/karma
that referenced
this issue
Jul 21, 2015
Use lower case file extension to detect if it is binary Closes karma-runner#1508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When serving static binary assets configured with:
Only images with *.jpg extensions are served properly. Capital letters extension shows a 'broken image' icon. This seems to be due to not recognising said image as a binary file. Adding "JPG" to
lib/binary-extensions.json
or modifyinglib/preprocessor.js
condition like so:Solves the problem.
Not sure how to write a failing test for this to submit a fix.
The text was updated successfully, but these errors were encountered: