-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autowatch with wildcards doesn't work #1249
Comments
@y-lohse can you create small(small as possible) gist which reproduce this problem. |
Yup, there you go: https://gist.github.com/y-lohse/4b09cdf3a2fae560a65f |
@y-lohse Thanks! |
@maksimr Is there a reason watcher doesn't use node-glob after https://github.com/karma-runner/karma/blob/master/lib/watcher.js#L23 |
@JetFault yup see comment |
@maksimr Maybe use minimatch's implementation for brace expansion? |
@JetFault maybe. Pull request are welcome :) |
Expands braces in watcher, so you can watch: ['a/{b,c}'] which would expand to ['a/b', 'a/c'] Closes karma-runner#1249
Expands braces in watcher, so you can watch: ['a/{b,c}'] which would expand to ['a/b', 'a/c'] Closes karma-runner#1249
Fix in canary branch |
Expands braces in watcher, so you can watch: ['a/{b,c}'] which would expand to ['a/b', 'a/c'] Closes #1249
Hi,
In my karma config, I am watching some files directly, and some via wildcards.
autowatch
is set to true and works fine for directly referenced files, but not for those who should be matched by wildcards.I don't think this is related to #895. I tried using diferent text editors and setting
usePolling
to true but to no effect.I'm using:
I'm attaching the watcher logs below. Sorry for the formatting... you know, windows "terminal" 😒
i can attach my karma conf if it helps but it's pretty standard. The files watched via wildcards are resolved in the logs above, but changes have no effect.
The text was updated successfully, but these errors were encountered: