-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to socket.io 1.0 #1220
Comments
We seem to be having an issue for this one already: #1147 |
And another one :-) Guess would be good to centralise the discussion in one place. |
Fix: #1258 |
Just commenting for subscribers to this issue that this affects BrowserStack stability. I've reported #1284 not noticing this one. |
This also seems to affect BrowserStack stability outside of OS X - see errors on the angular Travis CI such as https://travis-ci.org/angular/angular.js/jobs/48153879 |
Because Karma is using a very outdated Socket.io version, users have to download a 8 MB useless file (karma/node_modules/socket.io/node_modules/socket.io-client/node_modules/active-x-obfuscator/node_modules/zeparser/benchmark.html), which is not apparent in later Socket.io versions... Please update. |
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220.
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220.
@ everyone around here, There is working version with the latest socket.io in this PR #1404 But I need some real world tests to be sure it works, so please go ahead and try it out and report bugs 💣 |
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220.
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220.
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220.
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220.
What has happened? Karma |
[email protected] was an accidental release, which released the canary version into the stable branch, which it shouldn't have (that's why there is no tag of it on github or anything like that..) |
Also, I'm very sorry for all this chaos @mzgol :( |
Thanks for the info, @dignifiedquire; I didn't know Karma 0.12.32 was not released from |
I just published |
@dignifiedquire I can't currently test this version as |
😢 I hate peer dependencies.. |
Hi! I'd like to suggest to change the dependency on However, I think this should be fixed immediately, before even the upgrade to |
This is already fixed in the canary branch: https://github.com/karma-runner/karma/blob/canary/package.json#L214 |
I was suggesting that there be a hotfix, since Unless there will be a release in the next couple of days? |
This superseeds karma-runner#1257 and karma-runner#1258. Closes karma-runner#1220. Conflicts: package.json
No description provided.
The text was updated successfully, but these errors were encountered: