Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to socket.io 1.0 #1220

Closed
vojtajina opened this issue Oct 20, 2014 · 17 comments
Closed

Upgrade to socket.io 1.0 #1220

vojtajina opened this issue Oct 20, 2014 · 17 comments
Milestone

Comments

@vojtajina
Copy link
Contributor

No description provided.

@pkozlowski-opensource
Copy link
Member

We seem to be having an issue for this one already: #1147

@pkozlowski-opensource
Copy link
Member

And another one :-)
#252

Guess would be good to centralise the discussion in one place.

@dhimil
Copy link

dhimil commented Dec 3, 2014

Fix: #1258

@mgol
Copy link
Contributor

mgol commented Jan 16, 2015

Just commenting for subscribers to this issue that this affects BrowserStack stability. I've reported #1284 not noticing this one.

@juliemr
Copy link
Contributor

juliemr commented Jan 26, 2015

This also seems to affect BrowserStack stability outside of OS X - see errors on the angular Travis CI such as https://travis-ci.org/angular/angular.js/jobs/48153879

@sindresorhus
Copy link

Because Karma is using a very outdated Socket.io version, users have to download a 8 MB useless file (karma/node_modules/socket.io/node_modules/socket.io-client/node_modules/active-x-obfuscator/node_modules/zeparser/benchmark.html), which is not apparent in later Socket.io versions... Please update.

dignifiedquire added a commit to dignifiedquire/karma that referenced this issue May 15, 2015
dignifiedquire added a commit to dignifiedquire/karma that referenced this issue May 15, 2015
@dignifiedquire
Copy link
Member

@ everyone around here, There is working version with the latest socket.io in this PR #1404 But I need some real world tests to be sure it works, so please go ahead and try it out and report bugs 💣

@dignifiedquire dignifiedquire self-assigned this May 15, 2015
dignifiedquire added a commit to dignifiedquire/karma that referenced this issue May 17, 2015
dignifiedquire added a commit to dignifiedquire/karma that referenced this issue May 17, 2015
dignifiedquire added a commit to dignifiedquire/karma that referenced this issue May 17, 2015
@dignifiedquire dignifiedquire added this to the v1.0 milestone May 17, 2015
lygstate pushed a commit to lygstate/karma that referenced this issue May 27, 2015
@mgol
Copy link
Contributor

mgol commented May 27, 2015

What has happened? Karma 0.12.33 includes socket.io 0.9.16 whereas the previous 0.12.32 included socket.io 1.3.5... old bugs are back 😕

@dignifiedquire
Copy link
Member

[email protected] was an accidental release, which released the canary version into the stable branch, which it shouldn't have (that's why there is no tag of it on github or anything like that..)
0.12.33 was the first release to actually mirror what is on master on github again.
I'm going to merge the socket.io upgrade into canary today, so that way we 0.13.0-rc.1 should have the latest socket.io and as soon as I've fixed all the integration test issues I want to pull this into stable.

@dignifiedquire
Copy link
Member

Also, I'm very sorry for all this chaos @mzgol :(

@mgol
Copy link
Contributor

mgol commented May 27, 2015

Thanks for the info, @dignifiedquire; I didn't know Karma 0.12.32 was not released from master.

@dignifiedquire
Copy link
Member

I just published 0.13.0-rc.1 it has the latest socket.io version, please take it for a spin and report all the bugs

@mgol
Copy link
Contributor

mgol commented May 27, 2015

@dignifiedquire I can't currently test this version as grunt-karma declares a karma peerDependency at ~0.12.0 which prevents it from even installing.

@dignifiedquire
Copy link
Member

😢 I hate peer dependencies..

@necramirez
Copy link

Hi! I'd like to suggest to change the dependency on socket.io to NOT be a specific version. Right now, package.json specifies it to be EXACTLY 0.9.16: https://github.com/karma-runner/karma/blob/v0.12.36/package.json#L211

However, socket.io has no such release https://github.com/Automattic/socket.io/releases/tag/0.9.16 (maybe they accidentally deleted it?). Browsing the socket.io releases list, after 0.9.15, it skips 0.9.16, but there is a 0.9.17.

I think this should be fixed immediately, before even the upgrade to socket.io 1.x.

@dignifiedquire
Copy link
Member

This is already fixed in the canary branch: https://github.com/karma-runner/karma/blob/canary/package.json#L214

@necramirez
Copy link

I was suggesting that there be a hotfix, since master is currently broken, and I don't know how soon the next release will be.

Unless there will be a release in the next couple of days?

@dignifiedquire dignifiedquire modified the milestones: 0.13, v1.0 Jul 8, 2015
shirish87 pushed a commit to shirish87/karma that referenced this issue Aug 29, 2015
This superseeds karma-runner#1257 and karma-runner#1258.
Closes karma-runner#1220.

Conflicts:
	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants