Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow file pattern to specify binary #1070

Closed
tpodom opened this issue May 21, 2014 · 8 comments · May be fixed by saurabharch/HireDot2#2, saurabharch/Breezeblocks#2 or saurabharch/reelcool#1
Closed

Allow file pattern to specify binary #1070

tpodom opened this issue May 21, 2014 · 8 comments · May be fixed by saurabharch/HireDot2#2, saurabharch/Breezeblocks#2 or saurabharch/reelcool#1
Labels
help wanted type: feature

Comments

@tpodom
Copy link

tpodom commented May 21, 2014

What do you think about allowing the files pattern to override whether or not the file should be considered binary? The current implementation isn't configurable if using custom file extensions.
@mikesnare
Copy link

+1 for this. There are currently a bunch of other pull requests for one format or another. I'm currently stuck on the swf one.

@JimtotheB
Copy link

Yes, this needs to happen. As far as I can tell, loading files into a Blob is the only way to test working with user provided files. Currently all of my .xlsx test files are named .tar

@drkibitz
Copy link

Or use isbinaryfile as suggested before

@JimtotheB JimtotheB mentioned this issue Sep 25, 2014
Closed
@SheetJSDev
Copy link

If the list will be updated, please add the standard Office document format extensions. Incomplete list: ACCDB, ACCDT, DOCX, DOCM, DOTX, DOTM, XLAM, PPTX, PPTM, POTX, POTM, PPAM, PPSX, PPSM, SLDX, SLDM, XLSX, XLSM, XLTX, XLSM, XLSB, MDB, DOC, PPT, XLS, XLW

@arty-name
Copy link

👍 adding my vote on that. Though instead of "blacklisting" binary files Karma should whitelist text file. It really takes some time to figure out that the file loaded in the browser is not the one you have on disk, and why that happened.

kring added a commit to CesiumGS/cesium that referenced this issue Jan 5, 2015
@kring
Use my own fork of Karma.
87c304b 
It adds the ability to specify in file patterns whether the matching files should be considered binary files.  I'll open a Karma pull request with this soon because it fixes karma-runner/karma#1070.
joeyparrish added a commit to shaka-project/shaka-player that referenced this issue Feb 24, 2015
@joeyparrish
Rename assets.
4da469d 
* Rename the bear clip to reflect the fact that it is actually a webm
  clip, not an mp4.
* Rename the sidx, cues, and headers files so that karma does not treat
  them as text.  See also: karma-runner/karma#1070.

Change-Id: Ia73c233b32a34c57d45021d1cc130c0e0672bda0
@henryptung
Copy link

👍 My vote as well.

Also adding to the extensions list: .pbf, for protobufs.

I really don't like naming things .pbf.png...

@dignifiedquire
Copy link
Member

We should switch to using isbinaryfile for now.

@mramato mramato mentioned this issue Jan 21, 2016
Merged
@mramato
Copy link
Contributor

mramato commented Jan 21, 2016

I just opened #1816 to address this issue. It's my first karma pull request, so hopefully I followed all of the rules. If anyone is interested in trying it out, I'm happy to have feedback.

This was referenced Feb 22, 2020
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Nov 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type: feature
Projects
None yet
Milestone
No milestone
10 participants
@arty-name @tpodom @maksimr @dignifiedquire @drkibitz @mramato @henryptung @mikesnare @JimtotheB @SheetJSDev