Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't preprocess svg files anymore #1026

Closed
r3mi opened this issue Apr 12, 2014 · 0 comments · Fixed by #1027
Closed

Can't preprocess svg files anymore #1026

r3mi opened this issue Apr 12, 2014 · 0 comments · Fixed by #1027

Comments

@r3mi
Copy link
Contributor

r3mi commented Apr 12, 2014

I am trying to preprocess svg files with ng-html2js (for svg files referenced by ng-include, or templateUrl in directives).
This doesn't work:

Ignoring preprocessing (ng-html2js) /path/to/file.svg because it is a binary file

which is wrong because svg is not a binary file.
I think it is a regression introduced by #885
r3mi added a commit to r3mi/karma that referenced this issue Apr 12, 2014
@r3mi
fix(preprocessor): consider SVG files as text files, not binary files
ff28803 
Closes karma-runner#1026
@r3mi r3mi mentioned this issue Apr 12, 2014
Merged
This was referenced Sep 27, 2018
Merged
Closed
This was referenced May 25, 2019
Closed
Merged
@renovate renovate bot mentioned this issue Sep 28, 2019
Merged
1 task
@renovate renovate bot mentioned this issue Oct 11, 2019
Merged
1 task
@cmorell cmorell mentioned this issue Jun 3, 2020
Open
1 task
@renovate renovate bot mentioned this issue Aug 19, 2020
Closed
1 task
@renovate renovate bot mentioned this issue Apr 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(preprocessor): consider SVG files as text files, not binary files r3mi/karma
1 participant
@r3mi