Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: karma-runner/karma
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.0.3
Choose a base ref
...
head repository: karma-runner/karma
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.0.4
Choose a head ref
  • 4 commits
  • 11 files changed
  • 2 contributors

Commits on Feb 1, 2021

  1. fix: ensure that Karma supports running tests on IE 11 (#3642) 

    They were failing because of unsupported arrow function syntax in two places:
- in karma.spec.js file (only affecting Karma's own tests)
- in socket.io.js file installed from NPM, hence the dependency update (this affected Karma consumers)

Enabled BrowserStack tests on IE 11 to prevent regressions.
    @devoto13
    devoto13 authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    dbd1943 View commit details
    Browse the repository at this point in the history

  2. fix(cli): temporarily disable strict parameters validation (#3641) 

    As discussed in #3625 there are multiple cases, where Karma users rely on the possibility to pass arbitrary options/arguments to the karma CLI. These arguments are either handled in a `karma.conf.js` file or are consumed by Karma plugins. Given the disruptive effect of the strict parameters validation and the lack of the feasible workarounds, the feature is reverted until we have better understanding of the custom options/arguments use cases and can implement a solution which works for everybody.
    @devoto13
    devoto13 authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    9c755e0 View commit details
    Browse the repository at this point in the history

  3. fix(client): fix a false positive page reload error in Safari (#3643) 

    Previous code was susceptible to the race condition in Safari browser. Specifically below piece:

```
iframe.src = policy.createURL(url)
karmaNavigating = false
```

There is no guarantee that onbeforeunload event will be triggered synchronously after setting `iframe.src`. It was the case in Chrome and Firefox, but not in Safari, where this caused an error every test run. New approach resets the onbeforeunload handler before navigation is triggered by Karma itself to avoid the need for synchronization and this race condition altogether. The handler will be restored by the new context once it is loaded.

PS Code is a bit fragile as there is an implicit dependency on `onbeforeunload` from the context, but I can't think of a cleaner approach.
    @devoto13
    devoto13 authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    2a57b23 View commit details
    Browse the repository at this point in the history

  4. chore(release): 6.0.4 [skip ci] 

    ## [6.0.4](v6.0.3...v6.0.4) (2021-02-01)

### Bug Fixes

* **cli:** temporarily disable strict parameters validation ([#3641](#3641)) ([9c755e0](9c755e0)), closes [#3625](#3625)
* **client:** fix a false positive page reload error in Safari ([#3643](#3643)) ([2a57b23](2a57b23))
* ensure that Karma supports running tests on IE 11 ([#3642](#3642)) ([dbd1943](dbd1943))
    @semantic-release-bot
    semantic-release-bot committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    7cdb43e View commit details
    Browse the repository at this point in the history
Loading