@TylerGillson can you also add a reference to this GH issue in your PR, please?

@TylerGillson , I think it's nice to have appVersion specifying the container image version and also have a way to overwrite it if a user wants to in their own values.yaml or by explicitly setting it

e.g
"{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"

what do you think?

@TylerGillson , I think it's nice to have appVersion specifying the container image version and also have a way to overwrite it if a user wants to in their own values.yaml or by explicitly setting it

e.g "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"

what do you think?

@arbreezy @matthisholleville I was trying to stick with the K8s common label conventions. How about introducing app.k8sgpt.image instead?

Output of helm template k8sgpt charts/k8sgpt:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: k8sgpt
  namespace: "default"
  labels:
    helm.sh/chart: k8sgpt-1.0.0
    app.kubernetes.io/name: k8sgpt
    app.kubernetes.io/instance: k8sgpt
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/version: "0.2.4"
    app.k8sgpt.image: "ghcr.io/k8sgpt-ai/k8sgpt:v0.2.4"

@TylerGillson , I think it's nice to have appVersion specifying the container image version and also have a way to overwrite it if a user wants to in their own values.yaml or by explicitly setting it
e.g "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
what do you think?

@arbreezy @matthisholleville I was trying to stick with the K8s common label conventions. How about introducing app.k8sgpt.image instead?

Output of helm template k8sgpt charts/k8sgpt:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: k8sgpt
  namespace: "default"
  labels:
    helm.sh/chart: k8sgpt-1.0.0
    app.kubernetes.io/name: k8sgpt
    app.kubernetes.io/instance: k8sgpt
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/version: "0.2.4"
    app.k8sgpt.image: "ghcr.io/k8sgpt-ai/k8sgpt:v0.2.4"

I was talking about in deployment's template, how you could set the container image version, which is something quite common with OSS charts.

@arbreezy gotcha! Made the change you suggested now that I've understood you 😅

@AlexsJones, do we need a release-please annotation since appVersion will point to our latest released container image?

@AlexsJones, do we need a release-please annotation since appVersion will point to our latest released container image?

I think this would make sense

@AlexsJones, do we need a release-please annotation since appVersion will point to our latest released container image?

I think this would make sense

OK, I think expanding the _helpers labels function to include that label would make sense
WDYT @TylerGillson ?

@arbreezy @thschue I'm happy to make whatever changes you guys feel are necessary, but I'll need a little bit more detail please.

We already have app.kubernetes.io/version: "0.2.4" and I proposed app.k8sgpt.image: "ghcr.io/k8sgpt-ai/k8sgpt:v0.2.4". What exactly are you proposing that I add to the default labels?

It should work like in this manifest -> https://github.com/k8sgpt-ai/k8sgpt/blob/main/container/manifests/deployment.yaml#L22

@TylerGillson: Made two suggestions, then it should work ...