Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict annotation functionality to versions of Julia it works on #79

Merged
merged 2 commits into from
Apr 2, 2023
Merged

Restrict annotation functionality to versions of Julia it works on #79

merged 2 commits into from
Apr 2, 2023

Conversation

ericphanson
Copy link
Member

see #76

@ericphanson ericphanson requested a review from a team as a code owner April 2, 2023 18:27
@codecov
Copy link

codecov bot commented Apr 2, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (4867b26) 100.00% compared to head (a5b160a) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ericphanson ericphanson mentioned this pull request Apr 2, 2023
Open
@SaschaMann SaschaMann merged commit 1aec431 into julia-actions:main Apr 2, 2023
@ericphanson ericphanson deleted the patch-1 branch April 2, 2023 21:36
SaschaMann added a commit that referenced this pull request Apr 7, 2023
@SaschaMann
Add missing version check to test_harness
98a8ba7 
#79 introduced a version requirement for annotations for installing the dependencies but not for the code that adds the annotations, resulting in a dependency error for certain versions.

Fixes #80
@SaschaMann SaschaMann mentioned this pull request Apr 7, 2023
Merged
SaschaMann added a commit that referenced this pull request Apr 7, 2023
@SaschaMann
Add missing version check to test_harness (#81)
79a7e10 
#79 introduced a version requirement for annotations for installing the dependencies but not for the code that adds the annotations, resulting in a dependency error for certain versions.

Fixes #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaMann SaschaMann SaschaMann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericphanson @SaschaMann