chore(agents-api): Run sync system tool executions in new processes #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to bbd8656 in 1 minute and 18 seconds
More details
- Looked at
48lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. agents-api/agents_api/activities/execute_system.py:131
- Draft comment:
CatchingBaseExceptionis not recommended. Consider catching more specific exceptions instead. - Reason this comment was not posted:
Comment was on unchanged code.
2. agents-api/agents_api/activities/execute_system.py:118
- Draft comment:
await handler()is missing arguments. Ensure that necessary arguments are passed to the handler function. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_IFQ8Q85F9cREh6mr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
…lep-ai/julep into c/async-system-tool-execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Run synchronous system tool executions in separate processes using
ProcessPoolExecutorinexecute_system.py.ProcessPoolExecutorinexecute_system.pyto run synchronous handlers in separate processes.execute_systemto check if handler is coroutine; if not, run in executor.ProcessPoolExecutorandpartialimports.This description was created by
for bbd8656. It will automatically update as commits are pushed.