fix(agents-api): Switch to monkeypatching because everything is shit #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Singh Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 8c03d93 in 7 seconds
More details
- Looked at
415lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/autogen/openapi_model.py:205
- Draft comment:
Replacing class inheritance with monkey patching for validators can lead to maintenance challenges and unexpected behavior. Consider documenting this change clearly to avoid confusion for future developers. This comment applies to all similar changes in this PR. - Reason this comment was not posted:
Confidence changes required:50%
The PR replaces class inheritance with monkey patching for validators. This change is not ideal as it can lead to maintenance challenges and unexpected behavior. However, given the PR title and description, it seems the author is aware of the issues and has chosen this approach due to constraints. It's important to highlight this concern.
Workflow ID: wflow_HSe7bDXlWejbgkYE
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diwank Singh Tomer [email protected]
Important
Refactor validation logic using monkeypatching and add new models and custom types in
openapi_model.py.EvaluateStep,ToolCallStep,PromptStep,SetStep,LogStep,ReturnStep,YieldStep,IfElseWorkflowStep, andMapReduceStep.CreateTransitionRequestandCreateEntryRequestclasses.ChatMLContent,ChatMLRole,ChatMLSource,ExecutionStatus, andTransitionType.CreateTaskRequest,PatchTaskRequest, andUpdateTaskRequestusingConfigDict.This description was created by
for 8c03d93. It will automatically update as commits are pushed.