feat: Add API call tool type #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Singh Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 5339101 in 16 seconds
More details
- Looked at
449lines of code in7files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_gK1AaqWhyGYCAm8B
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
…elation Signed-off-by: Diwank Singh Tomer <[email protected]>
|
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to c24e57a in 46 seconds
More details
- Looked at
939lines of code in18files - Skipped
0files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. agents-api/agents_api/activities/task_steps/base_evaluate.py:56
- Draft comment:
Support for nested dictionaries inbase_evaluateis a significant change. Ensure that this does not break existing functionality. - Reason this comment was not posted:
Confidence changes required:50%
Thebase_evaluatefunction has been updated to handle nested dictionaries. This change should be noted for its potential impact on existing functionality.
2. agents-api/agents_api/autogen/Tasks.py:947
- Draft comment:
Support for nested dictionaries inToolCallStep.argumentsis a significant change. Ensure that this does not break existing functionality. - Reason this comment was not posted:
Confidence changes required:50%
TheToolCallStepclass has been updated to support nested dictionaries in theargumentsfield. This change should be noted for its potential impact on existing functionality.
3. agents-api/agents_api/autogen/Tools.py:151
- Draft comment:
The addition of adescriptionfield inApiCallDefis a significant change. Ensure that this does not break existing functionality. - Reason this comment was not posted:
Confidence changes required:50%
TheApiCallDefclass inTools.pyhas been updated to include adescriptionfield. This change should be noted for its potential impact on existing functionality.
4. agents-api/agents_api/models/tools/create_tools.py:68
- Draft comment:
The addition of adescriptionfield in tool records is a significant change. Ensure that this does not break existing functionality. - Reason this comment was not posted:
Confidence changes required:50%
Thecreate_toolsfunction increate_tools.pyhas been updated to include adescriptionfield in the tool records. This change should be noted for its potential impact on existing functionality.
5. agents-api/agents_api/models/tools/list_tools.py:36
- Draft comment:
The addition of adescriptionfield in tool records is a significant change. Ensure that this does not break existing functionality. - Reason this comment was not posted:
Confidence changes required:50%
Thelist_toolsfunction inlist_tools.pyhas been updated to include adescriptionfield in the tool records. This change should be noted for its potential impact on existing functionality.
Workflow ID: wflow_ehEvLpWPZcyPbns2
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 3fe372e in 15 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/tests/test_docs_queries.py:43
- Draft comment:
The TODO comment is vague. Consider providing more specific guidance or linking to an issue tracker for better clarity on how to resolve the test issue. - Reason this comment was not posted:
Confidence changes required:50%
The TODO comment suggests a known issue with the test, but it doesn't provide a clear path to resolution. This can be improved by providing more specific guidance or linking to an issue tracker.
Workflow ID: wflow_pIbmmkeU6lkGgPHQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
…ders back Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 326067a in 15 seconds
More details
- Looked at
32lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/activities/excecute_api_call.py:28
- Draft comment:
CatchingBaseExceptionis too broad and can lead to unintended behavior. Consider catching more specific exceptions likehttpx.HTTPStatusErrororException. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_qfgRWqiuaxvHzgx6
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add API call tool type and description field to agent tools, updating models and types accordingly.
ApiCallDefandApiCallDefUpdateclasses inTools.pyto define API call tools.api_callfield toCreateToolRequest,PatchToolRequest,UpdateToolRequest, andToolclasses inTools.py.descriptionfield toCreateToolRequest,PatchToolRequest,UpdateToolRequest, andToolclasses inTools.py.prepare_chat_context.pyandprepare_execution_input.pyto includedescriptionin tool data.execute_api_call()inexcecute_api_call.pyto handle API call execution.httpMethodalias inscalars.tspfor valid HTTP methods.ApiCallDefmodel inmodels.tspfor API call tools.create_tools.pyandlist_tools.pyto handledescriptionfield in tool records.migrate_1727922523_add_description_to_tools.pyto adddescriptionfield to tools table.workflow: tool call api_callintest_execution_workflow.pyto verify API call tool functionality.This description was created by
for 326067a. It will automatically update as commits are pushed.