feat(agents-api): Add static checking for Jinja templates & Python expressions in task creation | Add validation for subworkflows #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 6fa8605 in 16 seconds
More details
- Looked at
437lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. typespec/tasks/steps.tsp:53
- Draft comment:
YieldStepis duplicated in theNonConditionalWorkflowStepalias. Please remove the redundant entry. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_X3vnUqkhQc71S9ng
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
HamadaSalhab
changed the title
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 9952ad5 in 10 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_vjN86ojxZSZlOQaf
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #535
Important
Add static validation for Python expressions and Jinja templates in task creation and validate subworkflows in
openapi_model.pyandsteps.tsp.validate_python_expression()andvalidate_jinja_template()inopenapi_model.py.EvaluateStep,ToolCallStep,PromptStep,SetStep,LogStep,ReturnStep,YieldStep,IfElseWorkflowStep, andMapReduceStepinopenapi_model.py.CreateTaskRequestinopenapi_model.pyto validate subworkflows usingWorkflowType.YieldSteptoMappableWorkflowStepandNonConditionalWorkflowStepinsteps.tsp.YieldStepinTasks.pyto maintain consistency.This description was created by
for 9952ad5. It will automatically update as commits are pushed.