dev -> main #514
Merged
dev -> main #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
Vertex AI client
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 8b2bd54 in 36 seconds
More details
- Looked at
1422lines of code in63files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/clients/litellm.py:65
- Draft comment:
Avoid usinginputas a variable name since it's a built-in function in Python. Consider renaming it to something likeinput_data. - Reason this comment was not posted:
Confidence changes required:50%
The code inagents-api/agents_api/clients/litellm.pyhas a potential issue with the variable nameinputwhich is a built-in function in Python. It's better to avoid using built-in names for variables to prevent any unexpected behavior.
Workflow ID: wflow_bauFFgcqaG3asAfg
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Major update integrating
litellmfor embeddings, refining environment configurations, enhancing API endpoints, and updating Docker setups across services.embedclient withlitellminembed_docs.py,gather_messages.py, andembed.py.embed.pyand updatedlitellm.pyto includeaembedding()function.EMBEDDING_SERVICE_BASEfrom.env.exampleandenv.py.embedding_dimensionstoenv.py.docker-compose.ymlfiles across multiple services to refine service dependencies and environment variables.restart: unless-stoppedto several services for better resilience.routersdirectory.test_chat_routes.pyto reflect changes in embedding service and API endpoints.pyproject.tomlto bumplitellmversion to^1.46.7..gitignorefor certificate files inscheduler/cert/.This description was created by
for 8b2bd54. It will automatically update as commits are pushed.