Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Get PostgreSQL settings via env vars #509

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix: Get PostgreSQL settings via env vars #509

merged 2 commits into from
Sep 19, 2024

Conversation

whiterabbit1983
Copy link
Contributor

@whiterabbit1983 whiterabbit1983 commented Sep 19, 2024 •
edited by ellipsis-dev bot
Loading

[!IMPORTANT].
Update PostgreSQL settings in scheduler/docker-compose.yml to use environment variables for dynamic configuration..
.

  • Environment Variables:.
    • Updated DB, DB_PORT, and DB_HOST in scheduler/docker-compose.yml to use environment variables TEMPORAL_POSTGRES_DB, TEMPORAL_POSTGRES_PORT, and TEMPORAL_POSTGRES_HOST with default values..
  • Configuration:.
    • Allows dynamic configuration of PostgreSQL settings via environment variables, enhancing flexibility..
      .
      This description was created by Ellipsis for 1b87f6b. It will automatically update as commits are pushed.

ellipsis-dev[bot]
ellipsis-dev bot reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1b87f6b in 7 seconds

More details
  • Looked at 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. scheduler/docker-compose.yml:13
  • Draft comment:
    Consider providing a default value for POSTGRES_PWD to ensure the application can run with default settings if the environment variable is not set. However, be cautious with sensitive information and ensure it's not hardcoded in the source code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR introduces environment variables with default values for PostgreSQL settings, which is a good practice for flexibility and configuration management. However, there is a potential issue with the use of default values for sensitive information like passwords.

Workflow ID: wflow_IWwl6K3f363fhJyV

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit db6594f into dev Sep 19, 2024
1 of 2 checks passed
@creatorrr creatorrr deleted the x/infra-settings branch September 19, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellipsis-dev ellipsis-dev[bot] ellipsis-dev[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whiterabbit1983 @creatorrr