Add custom api key support to chat endpoint #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to a51e6f8 in 13 seconds
More details
- Looked at
71lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. agents-api/agents_api/clients/litellm.py:18
- Draft comment:
Consider re-adding the linemodel = f"openai/{model}"if the litellm proxy still requires this format for model names. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is speculative and does not provide strong evidence that the line needs to be re-added. It asks the author to consider a change based on a condition that is not verified. According to the rules, speculative comments should be removed unless there is strong evidence of an issue.
I might be missing some context about the requirements of the litellm proxy, but the comment does not provide this context either. The comment should be actionable and based on evidence, not speculation.
Even if there is missing context, the comment should have provided that context to be useful. Without it, the comment remains speculative and not actionable.
The comment should be deleted because it is speculative and does not provide strong evidence of an issue.
2. agents-api/agents_api/routers/sessions/chat.py:36
- Draft comment:
Ensure consistency in header alias usage across the codebase if other headers are used similarly. - Reason this comment was not posted:
Confidence changes required:50%
The addition ofx_custom_api_keyin thechatfunction is correctly implemented, but the usage ofHeaderwith alias should be consistent with other headers if any.
Workflow ID: wflow_feoUgOlRFgnkCXAh
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add custom API key support to chat endpoint
Summary:
Add support for custom API keys in chat endpoint by modifying
acompletion()andchat()functions and updating API specification.Key points:
acompletion()inlitellm.pyby introducingcustom_api_keyparameter.chat()inchat.pyto acceptX-Custom-Api-Keyheader and pass it toacompletion().endpoints.tspto includeX-Custom-Api-Keyas an optional header in thegenerateendpoint.Generated with ❤️ by ellipsis.dev